Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding colors to dark theme for #2376 #2377

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iannesbitt
Copy link
Contributor

Closes #2376

--portal-grey-5: #80868B;
--portal-grey-6: #5F6368;
--portal-grey-7: #3C4043;
--portal-grey-8: #202124;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ian! This color palette is specific to the light theme so I'd recommend not directly copying over the config from light.css. The issue described in the ticket is about layer category color, which is defined here. I think the fix should be two stepped:

  1. Set --portal-col-text-highlight in dark.css to a legible color in the context of dark theme. This variable is used by other components as well (.layer-details__label, .viewfinder-prediction__content) so you'll see a color change at those places. This fix will also only apply to portals that explicitly use the dark theme. Map in the main repo, for example, will still use the fallback color of --map-col-highlight__deprecate.

  2. To address the issue for non-theme users, we can replace the fallback color in map-view.css with the same color from # 1.

Copy link
Contributor Author

@iannesbitt iannesbitt Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yvonnesjy! Thank you, I appreciate the heads up and the detailed explanation. I just assumed that copying the blues and greys definitions to dark.css and changing the specific variable references would be sufficient to make the dark theme more legible without causing problems elsewhere. I can change to define them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors in portal dark theme layer list don't quite fit after update
2 participants